Expose around worker in Runtime builder #1557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jothan
suggested changes
Sep 14, 2019
hawkw
reviewed
Sep 14, 2019
| .unwrap() | ||
| .take() | ||
| .unwrap() | ||
| timers[index].lock().unwrap().take().unwrap() |
| @@ -58,6 +58,8 @@ pub struct Builder { | |||
|
|
|||
| /// The clock to use | |||
| clock: Clock, | |||
|
|
|||
| around_worker: Option<Arc<dyn Fn(&threadpool::Worker) + Send + Sync + 'static>>, | |||
There was a problem hiding this comment.
Nit: every other field has a doc comment, and this is one of the less self-explanatory fields IMO
Co-Authored-By: Eliza Weisman <eliza@buoyant.io>
carllerche
requested changes
Sep 18, 2019
| where | ||
| F: Fn(&threadpool::Worker) + Send + Sync + 'static, | ||
| { | ||
| self.threadpool_builder.around_worker(f); |
There was a problem hiding this comment.
This should set self.around_worker.
|
We probably should add a test too. |
|
I'm going to close this PR as I believe #1657 takes over, but thanks for doing the work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.